Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape context.pipelineConfig property for tests #291

Merged
merged 6 commits into from
May 10, 2024

Conversation

labkey-tchad
Copy link
Member

Rationale

Need properly escape file paths for application.properties.

Related Pull Requests

Changes

  • Escape context.pipelineConfig property for tests
  • Add some logging to SequenceRemoteIntegrationTests.java

@labkey-tchad labkey-tchad merged commit 51f1207 into release24.3-SNAPSHOT May 10, 2024
5 checks passed
@labkey-tchad labkey-tchad deleted the 24.3_fb_embedded_escapeFilePath branch May 10, 2024 15:11
@labkey-tchad
Copy link
Member Author

@labkey-tchad: do you think this failure is related to these changes and perhaps escaping paths on windows machines?

Yes. I changed develop to use embedded Tomcat but this fix hasn't merged forward yet. It will get merged tomorrow sometime and should be passing in our Thursday morning results.

@bbimber
Copy link
Collaborator

bbimber commented May 14, 2024

ok, just checking, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants