Euclid references #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just updated the text regarding the speclite zeropoint reference (and I think I should do another PR to update it like this for the other speclite surveys). I think we can merge as it is now and I am going to check in more details how to compute the effective wavelength for all surveys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update the Euclid references, related to issue #27.
Almost all is ok, except for:
zeropointcommon reference that we need to make Make a common reference for speclite zeropoints #48.central_wavelengthreference. The current value comes from BTK and WLD, itself coming from LSST throughputs. But I do not find the Euclid filters there. Instead, we may want to double check the value using the Euclid speclite filter responses, once we get confirmation about the way to compute it How are thecentral wavelengthsseen in Rubin parameters computed ? #36.