Adding missing gain values #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Looking good, thanks @mpaillassa |
aboucaud
pushed a commit
that referenced
this pull request
Feb 9, 2022
aboucaud
added a commit
that referenced
this pull request
Feb 13, 2022
* Add data README * Add file to package data * Add link to main README * Address Maxime comment * Update DES references (#42) * Adding missing gain values (#44) * Adding missing obscuration values (#46) * Rename exp_time to exposure_time (#47) * Update pre-commit * Update sky brightness definition * Fix exposure_time name * CFHT references (#51) * first rework * cfhtls exposure times * renaming to cfhtls * Include the effective wavelength * Add ismael's remarks Co-authored-by: mpaillassa <[email protected]> Co-authored-by: mpaillassa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #39 and aims to add the gain values for all surveys.