Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type hints for compatibility with NumPy 2.x #477

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

vitenti
Copy link
Collaborator

@vitenti vitenti commented Jan 6, 2025

Description

Update type hints for compatibility with NumPy 2.x

Type of change

More type-hints and numpy array explicit conversions to satisfy mypy and numpy 2.x.

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

@vitenti vitenti marked this pull request as ready for review January 6, 2025 19:07
@vitenti vitenti requested a review from marcpaterno January 6, 2025 19:07
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.9%. Comparing base (4cd7052) to head (28ad412).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #477   +/-   ##
======================================
  Coverage    99.9%   99.9%           
======================================
  Files          54      54           
  Lines        4163    4163           
======================================
  Hits         4160    4160           
  Misses          3       3           
Files with missing lines Coverage Δ
firecrown/connector/cobaya/ccl.py 100.0% <100.0%> (ø)
firecrown/connector/mapping.py 100.0% <100.0%> (ø)
firecrown/connector/numcosmo/numcosmo.py 99.7% <100.0%> (ø)
firecrown/data_functions.py 100.0% <100.0%> (ø)
firecrown/generators/two_point.py 100.0% <100.0%> (ø)
firecrown/likelihood/gaussfamily.py 100.0% <100.0%> (ø)
firecrown/likelihood/likelihood.py 100.0% <100.0%> (ø)
firecrown/likelihood/supernova.py 100.0% <100.0%> (ø)
firecrown/likelihood/two_point.py 99.5% <ø> (ø)
firecrown/models/cluster/abundance.py 100.0% <100.0%> (ø)
... and 2 more

@vitenti vitenti merged commit 4efc44a into master Jan 6, 2025
9 checks passed
@vitenti vitenti deleted the mypy_and_numpy2 branch January 6, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants