Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fits files #465

Closed
wants to merge 7 commits into from
Closed

Create fits files #465

wants to merge 7 commits into from

Conversation

pecom
Copy link
Contributor

@pecom pecom commented Oct 6, 2023

Adds functionality to save blended/deblended batches as FITS files.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (cef8222) 61.15% compared to head (ed30853) 57.96%.
Report is 1 commits behind head on dev.

Files Patch % Lines
btk/blend_batch.py 9.70% 93 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #465      +/-   ##
==========================================
- Coverage   61.15%   57.96%   -3.20%     
==========================================
  Files          19       19              
  Lines        1555     1658     +103     
==========================================
+ Hits          951      961      +10     
- Misses        604      697      +93     
Flag Coverage Δ
unittests 57.96% <9.70%> (-3.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Might you consider adding a unit test to ensure these functions work? There is an example in test_pipeline.py

@ismael-mendoza
Copy link
Collaborator

another question @pecom is the saving and loading with fits files useful to you for the DeblendBatch ? If not I would suggest not including it

@ismael-mendoza ismael-mendoza changed the base branch from main to dev December 1, 2023 18:25
@ismael-mendoza
Copy link
Collaborator

@pecom I'm closing this for now, is it finished? feel free to let me know or re-open if you are still interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants