Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for hdf5 saving (issue 442) #448

Merged
merged 6 commits into from
Sep 10, 2023
Merged

add support for hdf5 saving (issue 442) #448

merged 6 commits into from
Sep 10, 2023

Conversation

ismael-mendoza
Copy link
Collaborator

@ismael-mendoza ismael-mendoza commented Sep 6, 2023

Closes #442

  • how to save and load survey objects? add utility functions?
  • do we need to interpolate PSF image when loading it or just wrap around galsim.Image()?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ismael-mendoza ismael-mendoza changed the title add support for hdf5 saving (issue 442) add support for hdf5 saving (issue #442) Sep 6, 2023
@ismael-mendoza ismael-mendoza changed the title add support for hdf5 saving (issue #442) add support for hdf5 saving (issue 442) Sep 6, 2023
@ismael-mendoza ismael-mendoza changed the base branch from main to dev September 6, 2023 19:45
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 96.22% and project coverage change: +3.05% 🎉

Comparison is base (de35165) 59.47% compared to head (3424000) 62.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #448      +/-   ##
==========================================
+ Coverage   59.47%   62.53%   +3.05%     
==========================================
  Files          19       19              
  Lines        1498     1508      +10     
==========================================
+ Hits          891      943      +52     
+ Misses        607      565      -42     
Flag Coverage Δ
unittests 62.53% <96.22%> (+3.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
btk/blend_batch.py 72.03% <96.22%> (+19.82%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ismael-mendoza ismael-mendoza self-assigned this Sep 10, 2023
@ismael-mendoza ismael-mendoza merged commit 9120aaf into dev Sep 10, 2023
6 checks passed
@ismael-mendoza ismael-mendoza deleted the i/442 branch September 10, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use hdf5 format for loading and saving batches
1 participant