Implements RandomSquareSampling #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #443 +/- ##
==========================================
- Coverage 61.91% 60.39% -1.53%
==========================================
Files 19 19
Lines 1431 1472 +41
==========================================
+ Hits 886 889 +3
- Misses 545 583 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
2 tasks
ismael-mendoza
requested changes
Aug 25, 2023
There was a problem hiding this comment.
Sorry for the delay @atorchylo I have some small suggestions and a question
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ismael-mendoza
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
RandomSquareSamplingsampling function, which allows user to get a subset of input catalog of a needed size. UnlikeDefaultSampling, which selects galaxies randomly and then shifts them on the output image,RandomSquareSamplingselects galaxies that are physically close to each other.Closes #423