Im/propagate rotation #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 89.81% // Head: 89.81% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #391 +/- ##
========================================
Coverage 89.81% 89.81%
========================================
Files 11 11
Lines 1522 1522
========================================
Hits 1367 1367
Misses 155 155
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
thuiop
pushed a commit
that referenced
this pull request
Mar 8, 2023
* raw catalog was never added * propagate to pa_bulge and clarify documentation * forgot the other angle * module 360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed during the sprint week. For Catsim catalog, the rotation augmentation angle is added to
pa_bulgeandpa_disk. For COSMOS, I left it alone. It still given in thebtk_rotationcolumn, although I could be convinced to remove this column...