Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SourceNotVisible exception #386

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

b-biswas
Copy link
Collaborator

The code crashes when using the catsim catalog because when the source is not visible in one of the bands, render_single() returns None.
and None type has no attribute None.array

@b-biswas b-biswas changed the title handle the case for SourceNotVisible exception fix SourceNotVisible exception Oct 18, 2022
@b-biswas b-biswas changed the base branch from main to develop October 18, 2022 14:39
@b-biswas b-biswas added the bug Something isn't working label Oct 18, 2022
@ismael-mendoza ismael-mendoza added this to the 1.0.0 milestone Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 89.81% // Head: 89.76% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (f6972dd) compared to base (fd2f1aa).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #386      +/-   ##
===========================================
- Coverage    89.81%   89.76%   -0.06%     
===========================================
  Files           11       11              
  Lines         1522     1524       +2     
===========================================
+ Hits          1367     1368       +1     
- Misses         155      156       +1     
Flag Coverage Δ
unittests 89.76% <75.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
btk/draw_blends.py 91.08% <75.00%> (-0.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ismael-mendoza
Copy link
Collaborator

Thanks! Did this happen because you tried to use the bigger catalog? @b-biswas

@ismael-mendoza ismael-mendoza merged commit c36b185 into LSSTDESC:develop Nov 2, 2022
thuiop pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants