Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Im/python37 #334

Merged
merged 6 commits into from
Jul 11, 2022
Merged

Im/python37 #334

merged 6 commits into from
Jul 11, 2022

Conversation

ismael-mendoza
Copy link
Collaborator

@ismael-mendoza ismael-mendoza commented Jul 11, 2022

I realized it's actually easy to keep python37 support, and many external services still support it unfortunately (binder, colab).

I also add python 3.10 because why not

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #334 (324eaef) into develop (90622dc) will decrease coverage by 0.88%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop     #334      +/-   ##
===========================================
- Coverage    90.16%   89.27%   -0.89%     
===========================================
  Files           11       11              
  Lines         1433     1436       +3     
===========================================
- Hits          1292     1282      -10     
- Misses         141      154      +13     
Flag Coverage Δ
unittests 89.27% <50.00%> (-0.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
btk/__init__.py 77.77% <50.00%> (-22.23%) ⬇️
btk/measure.py 78.57% <0.00%> (-6.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90622dc...324eaef. Read the comment docs.

@ismael-mendoza ismael-mendoza merged commit a9ec44a into develop Jul 11, 2022
@ismael-mendoza ismael-mendoza deleted the im/python37 branch July 11, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant