-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for updated survey system #294
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## develop #294 +/- ##
========================================
Coverage 89.03% 89.03%
========================================
Files 13 13
Lines 1560 1560
========================================
Hits 1389 1389
Misses 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I am currently rewriting the “custom_tutorial” notebook ; it used to explain how to create a new survey. Should I remove that and restrict to modifying existing surveys, as it is now more complex to create new ones from scratch ? @ismael-mendoza |
aaa0648
to
56b6a00
Compare
I believe it should be ready for review @ismael-mendoza |
will take a look later today, thanks @thuiop ! |
View / edit / reply to this conversation on ReviewNB ismael-mendoza commented on 2022-04-22T00:54:08Z Why did you change the meas_band_name to meas_band_num ? ismael-mendoza commented on 2022-04-22T00:55:03Z (same below, I think there is another cell where you do this) thuiop commented on 2022-04-22T12:50:27Z Hmmm that's weird, I am pretty sure I actually did the reverse change somewhere. There may have been a rebase problem at some point. ismael-mendoza commented on 2022-04-22T13:13:22Z thanks! |
(same below, I think there is another cell where you do this) View entire conversation on ReviewNB |
Thanks @thuiop this is looking good- I just had a small comment in one of the notebooks (see above) |
Hmmm that's weird, I am pretty sure I actually did the reverse change somewhere. There may have been a rebase problem at some point. View entire conversation on ReviewNB |
thanks! View entire conversation on ReviewNB |
looks great, merging now |
No description provided.