Ensure PSF is consistently propagated if customized #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
=======================================
Coverage 85.85% 85.85%
=======================================
Files 13 13
Lines 1570 1570
=======================================
Hits 1348 1348
Misses 222 222
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ismael-mendoza
added a commit
that referenced
this pull request
Feb 25, 2022
* Simplify CLI with hydra instantiate (#230) * update poetry * more error checking in draw_blends for MR * bug in this line when using basic measure function and MR * catch error related to meas_band_num in metrics * use hydra instantiate and call rather than available_* * update documentation * test MR on main, remove error checking now done by hydra * Revert "update poetry" This reverts commit aad74ea. * Custom measurement functions (#231) * link the CLI tutorial * clarify that custom survey, measurement functions from CLI are not supported. * add need blank line * clarify how to add measure function if you are advanced user * fix url (#232) * fixing test * make test always predictable * pytest information in pyproject toml (#233) * Update CONTRIBUTING.md * More reproducibility (#237) * only able to provide seed not rng * only allow integer seeds, propagate to multiprocessing correctly * propagate changes to tests * correct seed defaults * fix tests bc seeds were not propagated correctly before * larger max int * Update btk/draw_blends.py Co-authored-by: Alexandre Boucaud <[email protected]> * Update btk/sampling_functions.py Co-authored-by: Alexandre Boucaud <[email protected]> * define default seed once * Update btk/sampling_functions.py Co-authored-by: Alexandre Boucaud <[email protected]> * dont need another rng embedded in render_blend * simplify line * seeds are now used in config * put defualt seed in init * show how to use the seed * add seed in tutorial documentation too * ignore warning until actually throws an error * fix tests with new seed * why did the precision decrease again? * no output in first cell Co-authored-by: Alexandre Boucaud <[email protected]> * Small fixes to the measure file (#242) * Small fixes to the measure file * Fixed pixel and world coordinates * Fixed notebooks * Small improvements tutorials (#243) * Renamed notebooks and added readme * Save in temporary directory in intro notebook * update name of ntoebooks in test.yml * remove mentions of coadd * warning about jupyterlab Co-authored-by: Ismael Mendoza <[email protected]> * Invisible shifts and indices (#244) * add notes to documentation for users about shifts/indexes * remove shifts/ indices from notebooks to avoid confusing users * Update CONTRIBUTING.md (#245) * Update CONTRIBUTING.md * Update CONTRIBUTING.md * trailing white space * Ensure PSF is consistently propagated if customized (#246) * should be a public method * remove mention of more examples that are non existant * fix urls (#247) * Fixed noise seed identical over a batch (#249) * Fixed noise seed identical over a batch * Rework seed management * Documentation for seeds * Changed behaviour to something more logical * Moved seed sequence initialization and renamed variables * remove galsim hub and tensorflow temporarily (#251) * remove galsim hub and tensorflow * forgot mention in --extras * Update notebooks/README.md Co-authored-by: thuiop <[email protected]> Co-authored-by: thuiop <[email protected]> * No capping (#252) * no capping, suppress warnings * update poetry * fix tests after updating * Separate noises (#254) * Separate the two noises * Updated tests * Possibility to choose which noise is drawn * Update doc and notebook * Changed lists to tuples * Fix test * Fix all tests * Updated notebooks * Revert change * Notebooks * Bump ipython from 7.31.0 to 7.31.1 (#257) Bumps [ipython](https://github.com/ipython/ipython) from 7.31.0 to 7.31.1. - [Release notes](https://github.com/ipython/ipython/releases) - [Commits](ipython/ipython@7.31.0...7.31.1) --- updated-dependencies: - dependency-name: ipython dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fetch flake8 from GitHub instead of GitLab (#260) Co-authored-by: Alexandre Boucaud <[email protected]> * update poetry adn pyproject w/ tqdm * fixing problem with add_noise (#264) * Run notebooks once a week in a separate workflow (#263) * Add progress bar * add description * new cron job for notebooks * update other workflows * remove push * forgot to remove notebooks in test.yml * use nbval-lax * clarify comment in new job * not sure why tqdm change was here * undo sanitize change * ignore nbval warning * fix warning Co-authored-by: thuiop <[email protected]> * Add progress bar (#258) * Add progress bar * add description * update poetry * add process to progress bar description * get current process function * sanitize progress bar * run notebooks with progress bar, removed autoreload syntax Co-authored-by: Ismael Mendoza <[email protected]> * Parametric cosmos simulations (#256) * parametric sims with cosmos cat * updated docstring * tutorial with parametric example * adding exclusion_level cuts * pre-commit changes * resolve pre-commit changes * using catalog directly from galsim * Update 01a-cosmos_tutorial.ipynb fixing kernel metadata * fixing kernel metadata * updating docstring * default exclusion_level as "marginal" * _selection.fits catalog * correcting path * added tests with parametric sims * updated config * removed assert on exclusion_level * updated add_noise Co-authored-by: thuiop <[email protected]> Co-authored-by: Alexandre Boucaud <[email protected]> Co-authored-by: Ismael Mendoza <[email protected]> * keep notebook output but remove metadata with nbstripout (#266) * keep output but remove metadata * add nbstripout to pre-commit * add nbstripout to dependencies * keep output nbstripout * error corrected * autoupdate * update poetry * black * black should be latest version * add notebook action badge (#267) Co-authored-by: Alexandre Boucaud <[email protected]> Co-authored-by: thuiop <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Biswajit Biswas <[email protected]>
ismael-mendoza
added a commit
that referenced
this pull request
Feb 25, 2022
* should be a public method * remove mention of more examples that are non existant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #235
This is already done consistently by using the
get_survey_from_cfgfunction which internally uses theget_psffunction inmain.py. Notebooks like the "custom tutorial" correctly demonstrate how to customize.