-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added checks for catalog-survey compatibility #223
Conversation
Codecov Report
@@ Coverage Diff @@
## main #223 +/- ##
==========================================
- Coverage 85.59% 85.45% -0.14%
==========================================
Files 13 13
Lines 1534 1554 +20
==========================================
+ Hits 1313 1328 +15
- Misses 221 226 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a simple and great solution. Thanks @thuiop !
COSMOS_CATALOG_PATHS = [ | ||
str(data_dir / "cosmos/real_galaxy_catalog_23.5_example.fits"), | ||
str(data_dir / "cosmos/real_galaxy_catalog_23.5_example_fits.fits"), | ||
] | ||
|
||
COSMOS_EXT_CATALOG_PATHS = [ | ||
str(data_dir / "cosmos/real_galaxy_catalog_26_extension_example.fits"), | ||
str(data_dir / "cosmos/real_galaxy_catalog_26_extension_example_fits.fits"), | ||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be defined in the conftest.py to be used by any test.
Also make sure you separate the "cosmos/xxx.fits"
into "cosmos" / "xxx.fits"
so that pathlib can resolve Windows filepath, otherwise there is no point in using pathlib.
Closes #207