Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks for catalog-survey compatibility #223

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Conversation

thuiop
Copy link
Collaborator

@thuiop thuiop commented Sep 29, 2021

Closes #207

@thuiop thuiop added tests Everything related to unit tests Ready for review For PR which should be reviewed labels Sep 29, 2021
@thuiop thuiop added this to the v1.0.0 milestone Sep 29, 2021
@thuiop thuiop self-assigned this Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #223 (197e0e6) into main (7076b74) will decrease coverage by 0.13%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   85.59%   85.45%   -0.14%     
==========================================
  Files          13       13              
  Lines        1534     1554      +20     
==========================================
+ Hits         1313     1328      +15     
- Misses        221      226       +5     
Flag Coverage Δ
unittests 85.45% <70.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
btk/draw_blends.py 83.67% <70.00%> (-1.22%) ⬇️
btk/metrics.py 95.23% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7076b74...197e0e6. Read the comment docs.

@ismael-mendoza ismael-mendoza self-requested a review October 1, 2021 14:32
Copy link
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a simple and great solution. Thanks @thuiop !

@ismael-mendoza ismael-mendoza merged commit fd13e72 into main Oct 1, 2021
@ismael-mendoza ismael-mendoza deleted the add-exceptions branch October 1, 2021 14:50
Comment on lines +19 to +28
COSMOS_CATALOG_PATHS = [
str(data_dir / "cosmos/real_galaxy_catalog_23.5_example.fits"),
str(data_dir / "cosmos/real_galaxy_catalog_23.5_example_fits.fits"),
]

COSMOS_EXT_CATALOG_PATHS = [
str(data_dir / "cosmos/real_galaxy_catalog_26_extension_example.fits"),
str(data_dir / "cosmos/real_galaxy_catalog_26_extension_example_fits.fits"),
]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be defined in the conftest.py to be used by any test.

Also make sure you separate the "cosmos/xxx.fits" into "cosmos" / "xxx.fits" so that pathlib can resolve Windows filepath, otherwise there is no point in using pathlib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review For PR which should be reviewed tests Everything related to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise nice exceptions when using incompatible catalogs
3 participants