Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New scarlet notebook #169

Merged
merged 10 commits into from
Jun 7, 2021
Merged

New scarlet notebook #169

merged 10 commits into from
Jun 7, 2021

Conversation

thuiop
Copy link
Collaborator

@thuiop thuiop commented Jun 7, 2021

@ismael-mendoza seems like you force-pushed the branch so the one on main is currently not the good one.

@thuiop thuiop added the bug Something isn't working label Jun 7, 2021
@thuiop thuiop requested a review from ismael-mendoza June 7, 2021 16:14
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@thuiop
Copy link
Collaborator Author

thuiop commented Jun 7, 2021

It should be ready to be merged now.

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #169 (a1c15fa) into main (e055e2f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   81.17%   81.17%           
=======================================
  Files          11       11           
  Lines        1222     1222           
=======================================
  Hits          992      992           
  Misses        230      230           
Flag Coverage Δ
unittests 81.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e055e2f...a1c15fa. Read the comment docs.

@ismael-mendoza
Copy link
Collaborator

oops, thanks for letting me know and for fixing it!

@ismael-mendoza ismael-mendoza merged commit a32ec70 into main Jun 7, 2021
@ismael-mendoza ismael-mendoza deleted the new-scarlet-notebook branch June 7, 2021 18:02
mpaillassa pushed a commit that referenced this pull request Jul 16, 2021
* Added SCARLET notebook

* Added small descriptive text and passed surveys as a measure_kwargs

* Added SCARLET notebook

* Added small descriptive text and passed surveys as a measure_kwargs

* Addressed comments

* Catch error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants