Added a cap on distance for matching and changed error handling on KSB #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 81.15% 81.15%
=======================================
Files 11 11
Lines 1215 1215
=======================================
Hits 986 986
Misses 229 229
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ismael-mendoza
requested changes
May 21, 2021
ismael-mendoza
previously approved these changes
May 26, 2021
There was a problem hiding this comment.
Thanks @thuiop , I think this is ready for merging, I'm just going to merge a few small commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #156 . It does not seem easy to print the blend number along with the error ; it would need to be passed as an argument to the target_meas function.