Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added small tutorial for cosmos #124

Merged
merged 3 commits into from
Mar 31, 2021
Merged

Added small tutorial for cosmos #124

merged 3 commits into from
Mar 31, 2021

Conversation

thuiop
Copy link
Collaborator

@thuiop thuiop commented Mar 30, 2021

Self explanatory. I will add it in the documentation too. If you want to run the notebook, you should remember to add the multiprocessing flag back, which I removed according to the other PR.

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #124 (b270406) into main (ab87076) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   76.83%   76.83%           
=======================================
  Files          10       10           
  Lines        1023     1023           
=======================================
  Hits          786      786           
  Misses        237      237           
Flag Coverage Δ
unittests 76.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab87076...b270406. Read the comment docs.

@thuiop
Copy link
Collaborator Author

thuiop commented Mar 30, 2021

Note : we should first merge the multiprocessing branch, maybe rebase this one and then merge it.

ismael-mendoza
ismael-mendoza previously approved these changes Mar 31, 2021
Copy link
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @thuiop , thanks for adding the tutorial. I think we can merge this too.

@ismael-mendoza ismael-mendoza merged commit fa353c1 into main Mar 31, 2021
@ismael-mendoza ismael-mendoza deleted the cosmos-tutorial branch March 31, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants