Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multiprocessing flag #123

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Remove multiprocessing flag #123

merged 2 commits into from
Mar 30, 2021

Conversation

thuiop
Copy link
Collaborator

@thuiop thuiop commented Mar 30, 2021

Following @aboucaud remark on another PR, I removed the multiprocessing flag which is redundant with the cpu number. Closes #120.

@thuiop thuiop added the refactor code refactoring label Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #123 (26c7386) into main (43024df) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   76.12%   76.07%   -0.05%     
==========================================
  Files          10       10              
  Lines         980      978       -2     
==========================================
- Hits          746      744       -2     
  Misses        234      234              
Flag Coverage Δ
unittests 76.07% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
btk/draw_blends.py 94.14% <ø> (-0.04%) ⬇️
btk/measure.py 70.00% <ø> (-0.38%) ⬇️
btk/multiprocess.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43024df...26c7386. Read the comment docs.

Copy link
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thuiop , looks great

Copy link
Collaborator

@aboucaud aboucaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thuiop thuiop merged commit 46d660f into main Mar 30, 2021
@thuiop thuiop deleted the multiprocessing branch March 30, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiprocessing and cpu # is redundant
3 participants