Skip to content

Commit

Permalink
get Scarlet working in CI (#427)
Browse files Browse the repository at this point in the history
* change?

* remove output

* fix .pylintrc

* is this better

* pybind11

* one more try

* what about in the build ?

* with scarlet

* add scarlet test

* pegein

* poetry

* poetry with pip

* lint update
  • Loading branch information
ismael-mendoza authored Aug 13, 2023
1 parent 61d066c commit 4387ef1
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,8 @@ jobs:
- name: Install Scarlet
run: |
pip install "pybind11[global]" peigen
git clone https://github.com/pmelchior/scarlet.git
cd scarlet; python setup.py install; cd ..
poetry run pip install "pybind11[global]" peigen
poetry run pip install git+https://github.com/pmelchior/scarlet.git
- name: Run black
run: |
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,12 @@ jobs:
- name: Install poetry dependencies
run: |
poetry install
poetry install --with scarlet
- name: Install Scarlet
run: |
pip install "pybind11[global]" peigen
git clone https://github.com/pmelchior/scarlet.git
cd scarlet; python setup.py install; cd ..
poetry run pip install "pybind11[global]" peigen
poetry run pip install git+https://github.com/pmelchior/scarlet.git
- name: Run Tests
run: |
Expand Down
2 changes: 1 addition & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ disable=
# when overriding methods you don't get to pick your arguments
unused-argument,

# sep raises this
# sep raises this
c-extension-no-member,


Expand Down
6 changes: 6 additions & 0 deletions tests/test_pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,3 +155,9 @@ def test_sep(data_dir):

assert recall(detected, matched) > 0.95
assert precision(detected, matched) > 0.95


def test_scarlet():
import scarlet

_ = scarlet.GaussianPSF(sigma=(0.6,) * 6)

0 comments on commit 4387ef1

Please sign in to comment.