Added database for plugins

[Rider21]

Added database, cookie manager for plugins
Added copying from webview localStorage, sessionStorage

[nyagami]

isnt cookie managed by React Native Network?

[Rider21]

Yes, they are managed, but you can't interact with them,
I made a wrapper under react-native-cookies/cookies, so from the plugin you can add, modify, check, delete site cookies

[nyagami]

Yes, they are managed, but you can't interact with them, I made a wrapper under react-native-cookies/cookies, so from the plugin you can add, modify, check, delete site cookies

But is cookie management that important. Instead of remove/edit one cookie, users can just open webview, old cookies will be overrided.

[Rider21]

I don't know, but this process can be automated with these functions.

[Rider21]

By the way, do you think I need to redo copying from webview of localStorage, sessionStorage objects via java (directly).
Right now it is implemented through injecting js code

[nyagami]

why do you use mmkv's delete method instead of storage instance's one

[Rider21]

It doesn't have access to localStorage, sessionStorage.

[nyagami]

  clearAll(pluginID: string): void {
    const keysToRemove = this.getAllKeys(pluginID);
    keysToRemove.forEach(key => this.delete(pluginID, key));
  }

but you declare this

[Rider21]

The storage.getAllKeys function will only return keys that were set using storage.set.
It will not return keys to localStorage, sessionStorage.
(these can only be retrieved via a separate instance and are read-only, example).

[nyagami]

There're some vulnerabilities,I can set/get/delete stored values in plugin A from plugin B code right?
Since we had plugin repositories feature, users could be nuked by some trollers

[Rider21]

Yes, it's true, it can be fixed.
But I don't see the point of fixing it. The running plugin has too many permissions.
They could just write something like.

import { MMKV } from 'react-native-mmkv';

const store = new MMKV({ id: 'plugin_db' });
store.clearAll();

[nyagami]

Yes, it's true, it can be fixed. But I don't see the point of fixing it. The running plugin has too many permissions. They could just write something like.

import { MMKV } from 'react-native-mmkv';

const store = new MMKV({ id: 'plugin_db' });
store.clearAll();

No, plugin does not have that privilege. They are literally standalone scripts and dont have module accesses.
The import keyword in plugin code is just a hack. import would be converted into declared require function which is refer to https://github.com/LNReader/lnreader/blob/e2d22a5b05a47b57e1f46ccfb6d8dd3ebb05bcc8/src/plugins/pluginManager.ts#L23C1-L38C3

[nyagami]

LGTM, Im going to test in devices

[nyagami]

You need to resolve Typescript errors. My editor is screaming