-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icons and splashscreen #974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove the new
prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all background actions in app use notification_icon
, so you have to update them all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3mb is a huge file, I dont think slow device can get the smooth animation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it now down to 2.5. This would be easier if I had access to adobe AE, can't do much about it now. After the lottiefiles team removes a bug in their own creator (which adds features that are not possible on mobile), I will recreate the animation there. Then it will look better and have only around 200kb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any specific reason for moving this value to a new file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, just because Android studio automatically extracted it.
implementation project(':react-native-lottie-splash-screen') | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is not necessary
autolinking
realme Q |
Most definitely not, could be a problem by how I created the animation. However they should have fixed the tool by now and I will try to complete the animation the proper way now. |
* 'master' of https://github.com/LNReader/lnreader: Feat: new icons and splashscreen (LNReader#974) Fix: Webview theme (LNReader#977)
finally finished with the addition of the new icon and creation of the new splashscreen.
untitled.mp4