Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icons and splashscreen #974

Merged
merged 5 commits into from
Feb 28, 2024
Merged

new icons and splashscreen #974

merged 5 commits into from
Feb 28, 2024

Conversation

CD-Z
Copy link
Collaborator

@CD-Z CD-Z commented Feb 25, 2024

finally finished with the addition of the new icon and creation of the new splashscreen.

image
image

untitled.mp4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove the new prefix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all background actions in app use notification_icon, so you have to update them all

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3mb is a huge file, I dont think slow device can get the smooth animation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it now down to 2.5. This would be easier if I had access to adobe AE, can't do much about it now. After the lottiefiles team removes a bug in their own creator (which adds features that are not possible on mobile), I will recreate the animation there. Then it will look better and have only around 200kb

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any specific reason for moving this value to a new file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just because Android studio automatically extracted it.

Comment on lines +161 to +162
implementation project(':react-native-lottie-splash-screen')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is not necessary
autolinking

@nyagami
Copy link
Member

nyagami commented Feb 28, 2024

realme Q
Android 11
There's a weird behavior after animation done in the app launching. My friend reported me. Is it normal
https://github.com/LNReader/lnreader/assets/86464880/64896a68-7846-4394-ad49-518a3bab8c9f

@CD-Z
Copy link
Collaborator Author

CD-Z commented Feb 28, 2024

Most definitely not, could be a problem by how I created the animation. However they should have fixed the tool by now and I will try to complete the animation the proper way now.

@nyagami nyagami merged commit 03b1947 into LNReader:master Feb 28, 2024
1 check passed
dagouzhi added a commit to htyf-mp-community/lnreader that referenced this pull request Feb 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants