Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epub parser for LNReader #754

Merged

Conversation

cactusoftheday
Copy link

Literally just my branch off of nyagami's. GL to whoever is working on this.

Copy link
Member

@rajarsheechatterjee rajarsheechatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cactusoftheday and @danisty for working on this.

Few points:

  1. The app's style options wouldn't override EPUB's styles.
  2. We can have a Local Source option in sources tab which shows all the EPUBs present in a directory set by the user.

@rajarsheechatterjee rajarsheechatterjee merged commit f53b0ea into LNReader:main Sep 2, 2023
@danisty
Copy link

danisty commented Sep 2, 2023

Thank you for taking the time to test it.

  1. The EPUB's styles are loaded as a style element, I'd have to look into how the app changes styles.
  2. That's a good idea! I'm down to implementing it as soon as I have some free time.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants