Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default language for browse source. #554

Merged
merged 16 commits into from
Feb 26, 2023
Merged

default language for browse source. #554

merged 16 commits into from
Feb 26, 2023

Conversation

nyagami
Copy link
Member

@nyagami nyagami commented Feb 18, 2023

To test this. please clear all all app data

@nyagami
Copy link
Member Author

nyagami commented Feb 19, 2023

of course for images fetching

nyagami and others added 13 commits February 20, 2023 21:26
@nyagami
update logic for loading img on reader.
5965365 
some sources should have headers when fetch image data
@nyagami
minor fix
76ea77f
@nyagami
fix warning: 2 childs have the same key
0730f06
@SkillGG
fix(download): Download chapter image fixes
8596a6c 
- Saving images in binary form, not utf-8 base64 so that gallery etc can see them
- Downloads work with new WebViewReader's image loading features
- Added loading icons when images are loading asynchronusely
@SkillGG
fix(dq.ts): DownloadQueries type
0ea8d7d
@SkillGG
fix(img): remove delayed-src from downloaded imgs
5d822a4
@SkillGG
fix(download): Fix promise rejection and css issue
022033e 
- Fix promise rejection when trying to overwrite image file (shouldn't happen in production, but it miraculously did in dev)
- Fix CSS class 'loadIcon' not being applied to downladed chapter image loader icons and loader spinners not spinning
- Made loader spinners smaller. Now they look "a bit better" (according to my friend whom I showed the spinners)
@SkillGG
fix(loadimg): Change loadImage to smaller one
ea5fe3f
@SkillGG
fix(loadImg): change the class to load-img
573b26c
@nyagami
Merge pull request #1 from SkillGG/fixDownload
2855353 
fix(download): Download chapter image fixes
@nyagami
minor fix
595a7e3
@nyagami
fix hako source: popular novels and novel cover
e7503c7
@nyagami
update sendHeight logic
13c9b06
@nyagami
Copy link
Member Author

nyagami commented Feb 23, 2023

Done job.
From now, if there's any source have trouble with resources (mostly images). It should have headers (option) defined to bypass cloudflare (example: Hako). Otherwise, dont use headers

@rajarsheechatterjee rajarsheechatterjee merged commit 3289f35 into LNReader:main Feb 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rajarsheechatterjee rajarsheechatterjee rajarsheechatterjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyagami @rajarsheechatterjee @SkillGG