fix slider displays uncorrectly, rearrange seekbar props #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also need percen of device height as float. Format readerscreen.js easilier to read (at least for me :>)
|
This fix will reduce number of rerendering of ReaderScreen from 12 to 9. |
removal duplicate var
Need to implement save position. And sync TextView and WebView
Still issue when turn back from web to text. It cant scroll back.
|
Havent tested in special cases. But I think the seekbar can work quite well from this xD |
rajarsheechatterjee
approved these changes
Feb 13, 2023
|
Tested the build on emulator, the scroll position is being reset to top in |
|
I was quite confused about this thing. Maybe I should add (content size > 0) condition to doSaveProgress() |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slider inside Seekbar component