Fix issues reported by pre-alpha users - patch 2 (#906)

* delete background_action key before action done

* force to delete BACKGROUND_ACTION.
in case app is shutdowned while running bg actions

App.tsx

@@ -10,6 +10,7 @@ import LottieSplashScreen from 'react-native-lottie-splash-screen';
 import { SafeAreaProvider } from 'react-native-safe-area-context';
 import { Provider as PaperProvider } from 'react-native-paper';
 import * as Notifications from 'expo-notifications';
+import BackgroundService from 'react-native-background-actions';
 
 import { createTables } from '@database/db';
 import AppErrorBoundary from '@components/AppErrorBoundary/AppErrorBoundary';
@@ -18,6 +19,8 @@ import { collectPlugins } from '@plugins/pluginManager';
 import Main from './src/navigators/Main';
 import { BottomSheetModalProvider } from '@gorhom/bottom-sheet';
 import { usePlugins } from '@hooks/persisted';
+import { MMKVStorage } from '@utils/mmkv/mmkv';
+import { BACKGROUND_ACTION } from '@services/constants';
 
 Notifications.setNotificationHandler({
   handleNotification: async () => {
@@ -35,6 +38,9 @@ const App = () => {
     createTables();
     collectPlugins().then(() => LottieSplashScreen.hide());
     refreshPlugins();
+    if (!BackgroundService.isRunning()) {
+      MMKVStorage.delete(BACKGROUND_ACTION);
+    }
   }, []);
 
   return (

src/hooks/persisted/useDownload.ts

@@ -53,14 +53,14 @@ const downloadChapterAction = async (taskData?: TaskData) => {
       }
     }
   } finally {
+    MMKVStorage.delete(BACKGROUND_ACTION);
     await Notifications.scheduleNotificationAsync({
       content: {
         title: 'Downloader',
         body: 'Download completed',
       },
       trigger: null,
     });
-    MMKVStorage.delete(BACKGROUND_ACTION);
     BackgroundService.stop();
   }
 };

src/services/backup/drive/index.ts

@@ -87,10 +87,10 @@ const driveBackupAction = async (taskData?: TaskData) => {
         },
         trigger: null,
       });
-      await BackgroundService.stop();
     }
   } finally {
     MMKVStorage.delete(BACKGROUND_ACTION);
+    await BackgroundService.stop();
   }
 };
 
@@ -172,10 +172,10 @@ const driveRestoreAction = async (taskData?: TaskData) => {
         },
         trigger: null,
       });
-      await BackgroundService.stop();
     }
   } finally {
     MMKVStorage.delete(BACKGROUND_ACTION);
+    await BackgroundService.stop();
   }
 };
 

src/services/backup/legacy/index.ts

@@ -50,6 +50,7 @@ export const createBackup = async () => {
     showToast(error.message);
   } finally {
     MMKVStorage.delete(BACKGROUND_ACTION);
+    BackgroundService.stop();
   }
 };
 
@@ -122,6 +123,7 @@ export const restoreBackup = async (filePath?: string) => {
                   },
                   trigger: null,
                 });
+                MMKVStorage.delete(BACKGROUND_ACTION);
                 resolve();
               }
 
@@ -170,8 +172,6 @@ export const restoreBackup = async (filePath?: string) => {
     }
   } catch (error: any) {
     showToast(error.message);
-  } finally {
-    MMKVStorage.delete(BACKGROUND_ACTION);
   }
 };
 

src/services/migrate/migrateNovel.ts

@@ -225,6 +225,7 @@ export const migrateNovel = async (
         }
       } finally {
         MMKVStorage.delete(BACKGROUND_ACTION);
+        BackgroundService.stop();
       }
     };
     await BackgroundService.start(veryIntensiveTask, options);

src/services/updates/index.ts

@@ -109,6 +109,7 @@ const updateLibrary = async (categoryId?: number) => {
       }
     } finally {
       MMKVStorage.delete(BACKGROUND_ACTION);
+      BackgroundService.stop();
     }
   };