Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix(ui): add missing channel search cancel button #1519

Merged
merged 1 commit into from
Feb 7, 2019
Merged

fix(ui): add missing channel search cancel button #1519

merged 1 commit into from
Feb 7, 2019

Conversation

mrfelton
Copy link
Member

@mrfelton mrfelton commented Feb 7, 2019

Description:

Make channel filter widget consistent UX as other search fields.

Motivation and Context:

Fix #1517

How Has This Been Tested?

Manually

Screenshots (if appropriate):

image

Types of changes:

Fix / Enhancement

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added type: bug 🐛 Something isn't working type: enhancement labels Feb 7, 2019
@mrfelton mrfelton added this to the v0.3.4-beta milestone Feb 7, 2019
@mrfelton mrfelton self-assigned this Feb 7, 2019
@mrfelton mrfelton requested a review from korhaliv February 7, 2019 13:15
@mrfelton mrfelton force-pushed the fix/channel-search-widget branch from 14d06bf to 7046956 Compare February 7, 2019 13:22
korhaliv
korhaliv approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@korhaliv korhaliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 7046956

@mrfelton mrfelton force-pushed the fix/channel-search-widget branch from 7046956 to fad18df Compare February 7, 2019 18:01
@lieteau2 lieteau2 mentioned this pull request Feb 7, 2019
Closed
51 tasks
@mrfelton mrfelton merged commit b8ff9f2 into LN-Zap:master Feb 7, 2019
@mrfelton mrfelton deleted the fix/channel-search-widget branch February 7, 2019 18:25
@mrfelton mrfelton added type: enhancement New feature or request and removed type: enhancement type: enhancement New feature or request labels Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@korhaliv korhaliv korhaliv approved these changes

Assignees

@mrfelton mrfelton

Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.3.4-beta
Development

Successfully merging this pull request may close these issues.

Clear button is missing for search channels input
2 participants
@mrfelton @korhaliv