Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woptim/quotes for specs #84

Merged
merged 4 commits into from
Jul 25, 2022
Merged

Woptim/quotes for specs #84

merged 4 commits into from
Jul 25, 2022

Conversation

adrienbernede
Copy link
Member

In this PR I add single quotes around Spack specs to work around an issue in Spack with complex flags parsing.
(see spack/spack#31214).

This issue arise when using Spack newer than spack/spack@0c7fd9b.

There is one caveat: With this change the spec in CI should always use double quotes, and flag quotes should be protected:

-    SPEC: "~fortran %[email protected]+libcpp cxxflags='-stdlib=libc++ -DGTEST_HAS_CXXABI_H_=0' cflags='-DGTEST_HAS_CXXABI_H_=0'"
+    SPEC: "~fortran %[email protected]+libcpp cxxflags=\"-stdlib=libc++ -DGTEST_HAS_CXXABI_H_=0\" cflags=\"-DGTEST_HAS_CXXABI_H_=0\""

So this may be breaking for some projects, but easily fixable.

uberenv.py Outdated Show resolved Hide resolved
@adrienbernede
Copy link
Member Author

Changes validated in Umpire, release notes updated accordingly.

Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adrienbernede !

@adrienbernede adrienbernede merged commit 46252e4 into master Jul 25, 2022
@white238 white238 deleted the woptim/quotes-for-specs branch October 19, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants