Simplify displacement BC interface #1274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to write one function and reuse it for each of the desired components.
The bug was that the mfem entity id vectors (eg, mfem_edge_ids_) were not populated, which means that the dof_list function was unable to find any dofs. Even worse, no error was thrown, you would just get an empty dof_list. The calculation would continue, but with the dofs left out of whatever operations you used. This commit fixes the bug by removing the repeated code in the Entire* functions. Now they use the factory functions used for domain creation with spatial predicates, and just send a predicate that is always true. The only downside is that the Entire* functions now need a template paramater for the spatial dimension. Seems a good trade-off to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.