Option to increase problem size of nonlinear solve benchmark (small or large) #1251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of improving performance analysis #1226.
This PR...
Adds a
-s
option to the solid nonlinear solve benchmark, where you can specify the problem size of the benchmark. ASMALL
problem size takes under 5 seconds. This could be used to test whether the benchmark is working as intended. ALARGE
problem size takes about 5 minutes with 16 tasks. This should be used to measure performance.The motivation behind increasing the problem size is we want our benchmarks to be large enough to give us more accurate timing information. I figured I would do this before I start adding benchmarks to CI.
I tried adding an extra 0 to the large problem size and got
std::bad_alloc
: