Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds run_benchmarks CMake target and adapt existing test to be a benchmark #1222

Merged
merged 21 commits into from
Sep 11, 2024
Merged

Adds run_benchmarks CMake target and adapt existing test to be a benchmark #1222

merged 21 commits into from
Sep 11, 2024

Conversation

chapman39
Copy link
Contributor

@chapman39 chapman39 commented Aug 23, 2024 •
edited
Loading

  • Updates solid nonlinear solver example to run specific combinations of solvers one after another
    • Optionally, you can supply the exec nonlinear solver/ preconditioner options to override this
  • Create custom cmake target that will run all current benchmarks by just running make run_benchmarks
  • Update documentation
  • Update BLT with bugfix Prevent general tests from running while running benchmarks custom target blt#698

@chapman39 chapman39 added WIP Work in progress build Build system labels Aug 23, 2024
@chapman39 chapman39 self-assigned this Aug 23, 2024
@chapman39 chapman39 marked this pull request as draft August 23, 2024 00:43
@chapman39 chapman39 changed the title Run Benchmarks Script for SPOT analysis Benchmarking Improvements Sep 5, 2024
@chapman39 chapman39 changed the title Benchmarking Improvements Adds run_benchmarks CMake target and adapt existing test to be a benchmark Sep 5, 2024
@chapman39 chapman39 added the testing Related to testing label Sep 5, 2024
@chapman39
Copy link
Contributor Author

chapman39 commented Sep 9, 2024 •
edited
Loading

Docs: https://serac.readthedocs.io/en/feature-chapman39-spot/sphinx/dev_guide/profiling.html#benchmarking-serac

@chapman39 chapman39 marked this pull request as ready for review September 9, 2024 22:52
@chapman39 chapman39 removed the WIP Work in progress label Sep 9, 2024
@chapman39
Copy link
Contributor Author

I'll wait to merge until the related BLT pr is merged, but this PR is ready for review

@chapman39
Copy link
Contributor Author

Future benchmarking plans are outlined here #1226

@chapman39 chapman39 mentioned this pull request Sep 11, 2024
Open
chapman39
chapman39 commented Sep 11, 2024
View reviewed changes
src/docs/sphinx/dev_guide/profiling.rst
cd <serac build location>
make -j
make run_benchmarks
find . -name "*.cali" -print0 | xargs -0 mv -t .
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@white238 Added this part to the docs just now. The Caliper files will not be located at the root of the build dir by default.

It's somewhat unfortunate we have to do that command but it might be avoidable in the future if blt_add_test and blt_add_benchmark added a WORKING_DIRECTORY option. https://cmake.org/cmake/help/latest/command/add_test.html#add-test

@chapman39 chapman39 merged commit 568d299 into develop Sep 11, 2024
1 of 2 checks passed
@chapman39 chapman39 mentioned this pull request Sep 16, 2024
Merged
@chapman39 chapman39 deleted the feature/chapman39/spot branch November 7, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tupek2 tupek2 tupek2 approved these changes

@btalamini btalamini btalamini approved these changes

@white238 white238 white238 approved these changes

Assignees

@chapman39 chapman39

Labels
build Build system testing Related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chapman39 @white238 @btalamini @tupek2