Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate enums of nonlinear solvers and preconditioners #1231

Open
chapman39 opened this issue Sep 11, 2024 · 1 comment
Open

Consolidate enums of nonlinear solvers and preconditioners #1231

chapman39 opened this issue Sep 11, 2024 · 1 comment

Comments

@chapman39
Copy link
Contributor

          These maps and string things can potentially move into the library.  In fact, I made something similar  a few months back. [see inline std::string nonlinearName(const NonlinearSolver& s), line ~159 in solver_config.hpp].  Maybe think about consolidating those designs.  I'm not particular to the way I did it, so just choose one and put it all in solver_config.hpp?

Originally posted by @tupek2 in #1222 (comment)

@chapman39
Copy link
Contributor Author

benchmark_solid_nonlinear_solve.cpp and solvers_config.hpp have conflicting enums and we should just use one. this might lead to reorganizing the benchmark, since there is no linear solver option. instead some linear solver options are put into the preconditioner enum, for example STRUMPACK.

https://github.com/LLNL/serac/pull/1222/files#diff-4e5ed49121ba3a516e4cc5c5b6ddfe1bb805da4096412c7d8ee6d118c2c27e2eR156-R160

https://github.com/LLNL/serac/blob/develop/src/serac/numerics/solver_config.hpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant