Guard buckling example against no-petsc build #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapman39
added
bug
tupek2
reviewed
Aug 22, 2024
Yes. The other option would be to combine all the disable-X (tribol, sundials, petsc) into one job, but that wouldn't be as robust. |
|
I would vote to try and reduce our testing overhead. I think its becoming way too much of a bottleneck. Combining them would be OK with me, its not clear what scenario that would be missing. |
|
im going to remove the extra job from this PR for now and create a separate issue. since in any case we should resolve the buckling example issue. |
chapman39
changed the title
tupek2
approved these changes
Aug 26, 2024
white238
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if petsc is found for the new-ish buckling example.
Fixes #1216