Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard buckling example #1216

Closed
chapman39 opened this issue Aug 21, 2024 · 0 comments · Fixed by #1217
Closed

Guard buckling example #1216

chapman39 opened this issue Aug 21, 2024 · 0 comments · Fixed by #1217
Assignees
Labels
bug Something isn't working build Build system CI Continuous Integration

Comments

@chapman39
Copy link
Contributor

I found this error when building LiDO codeveloping Serac. LiDO does not enable PETSc by default (though perhaps we should), which caused this error.

/usr/workspace/meemee/lido-2.0/repo/smith/serac/examples/buckling/cylinder.cpp:46:52: error: no member named 'stringToPetscPCType' in namespace 'serac::mfem_ext'
  return std::to_string(static_cast<int>(mfem_ext::stringToPetscPCType(in)));
                                         ~~~~~~~~~~^
/usr/workspace/meemee/lido-2.0/repo/smith/serac/examples/buckling/cylinder.cpp:103:62: error: no member named 'stringToPetscPCType' in namespace 'serac::mfem_ext'
            return std::to_string(static_cast<int>(mfem_ext::stringToPetscPCType(in)));
                                                   ~~~~~~~~~~^

The buckling example should also be guarded with PETSC_FOUND. https://github.com/LLNL/serac/blob/develop/examples/buckling/CMakeLists.txt#L7

if(TRIBOL_FOUND AND PETSC_FOUND)
    blt_add_executable( NAME        buckling_cylinder
                        SOURCES     cylinder.cpp
                        OUTPUT_DIR ${EXAMPLE_OUTPUT_DIRECTORY}
                        DEPENDS_ON  serac_physics serac_mesh
                        )
endif()

To prevent things like this, it may be beneficial to add a test that disables PETSc, similar to what we do with Tribol and Sundials. And to minimize the number of jobs, maybe we could also mash the disable-X tests together? (i.e. test no petsc, sundials, tribol all together?)

@chapman39 chapman39 added bug Something isn't working CI Continuous Integration build Build system labels Aug 21, 2024
@chapman39 chapman39 self-assigned this Aug 21, 2024
@chapman39 chapman39 changed the title Test no-petsc in CI Test no-petsc in CI and guard buckling example Aug 21, 2024
@chapman39 chapman39 changed the title Test no-petsc in CI and guard buckling example Guard buckling example Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Build system CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant