Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test tree for lustre 2.10.8/zfs #50

Closed
wants to merge 1 commit into from
Closed

add test tree for lustre 2.10.8/zfs #50

wants to merge 1 commit into from

Conversation

ofaaland
Copy link
Contributor

Add /sys and /proc content to lustre_versions
Add expected 2.10.8 output files for all tests

Adjust test driver to detect version >= 2.10 and
not attempt to dump brw stats that no longer
exist.

Fixes #46

Testing:
Ran make check

@ofaaland
add test tree for lustre 2.10.8/zfs
758d79a 
Add /sys and /proc content to lustre_versions
Add expected 2.10.8 output files for all tests

Adjust test driver to detect version >= 2.10 and
not attempt to dump brw stats that no longer
exist.

Fixes LLNL#46

Signed-off-by: Olaf Faaland <[email protected]>
@ofaaland
Copy link
Contributor Author

ofaaland commented Dec 3, 2019 •
edited
Loading

<poke> :)

morrone
morrone reviewed Dec 3, 2019
View reviewed changes
Copy link
Member

@morrone morrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really familiar with that part of the code. If it works for you, that'ss good enough for me.

@ofaaland
Copy link
Contributor Author

ofaaland commented Dec 3, 2019 •
edited
Loading

I'm not really familiar with that part of the code. If it works for you, that'ss good enough for me.

OK, fair enough. Thank you.

tonyhutter
tonyhutter approved these changes Dec 3, 2019
View reviewed changes
Copy link

@tonyhutter tonyhutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I'm also unfamiliar with this code. It looks relatively harmless, so approved.

@ofaaland
Copy link
Contributor Author

ofaaland commented Dec 3, 2019

Mostly Harmless wins the day. Thanks!

@ofaaland
Copy link
Contributor Author

Merged as

  • 448da2d add test tree for lustre 2.10.8/zfs

@ofaaland ofaaland closed this Dec 10, 2019
@ofaaland ofaaland deleted the b-issue-46-squash branch December 10, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrone morrone morrone left review comments

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No tests for Lustre 2.10.x
3 participants
@ofaaland @morrone @tonyhutter