recursively eval in config/x_ac_expand_install_dirs.m4 #45
+70
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @morrone @tonyhutter can you take a look at this? Thanks! |
morrone
reviewed
Nov 9, 2019
There was a problem hiding this comment.
I'm going to recommend that you get current latest from the autoconf archive project (named AX_RECURSIVE_EVAL):
https://www.gnu.org/software/autoconf-archive/ax_recursive_eval.html
http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_recursive_eval.m4
${prefix} is left unexpanded in some path defines processed by
config/x_ac_expand_install_dirs.m4. Some macros then include the
literal string "${prefix}" in their values as reflected in
config/config.h.
#define X_DATADIR "${prefix}/share"
#define X_INFODIR "${prefix}/share/info"
#define X_MANDIR "${prefix}/share/man"
Add AX_RECURSIVE_EVAL() and use it to recursively evaluate the
macros in config/x_ac_expand_install_dirs.m4.
Fixes LLNL#44
Signed-off-by: Olaf Faaland <[email protected]>
Good idea. Done. |
morrone
approved these changes
Nov 11, 2019
|
Cherry-picked to master as b15d2bf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${prefix} is left unexpanded in some path defines processed by
config/x_ac_expand_install_dirs.m4. Some macros then include the
literal string "${prefix}" in their values as reflected in
config/config.h.
#define X_DATADIR "${prefix}/share"
#define X_INFODIR "${prefix}/share/info"
#define X_MANDIR "${prefix}/share/man"
Add adl_RECURSIVE_EVAL() and use it to recursively evaluate the macros
in config/x_ac_expand_install_dirs.m4.
Fixes #44