follow symlinks under /proc #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under Lustre 2.8 and 2.10 at least, /proc/fs/lustre/osc contains links to objects in /proc/fs/lustre/osc. Prior to Lustre 2.4 at least, there were subdirectories there. The lmt code for reading /proc directories, proc_readdir(), takes a flag to indicate whether files or subdirectories are being searched for. If the flag for finding subdirectories, PROC_READDIR_NOFILE, is passed, symlinks should be not be skipped as they may point to subdirectories. Credit to @6speedlt1 on github for identifying the fix. Fixes LLNL#30. Signed-off-by: Olaf Faaland <[email protected]>
dinatale2
approved these changes
Oct 26, 2019
morrone
approved these changes
Nov 9, 2019
|
Cherry-picked to master at 8eed365 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Lustre 2.8 and 2.10 at least, /proc/fs/lustre/osc contains
links to objects in /proc/fs/lustre/osc. Prior to Lustre 2.4 at
least, there were subdirectories there. The lmt code for
reading /proc directories, proc_readdir(), takes a flag to indicate
whether files or subdirectories are being searched for.
If the flag for finding subdirectories, PROC_READDIR_NOFILE, is
passed, symlinks should be not be skipped as they may point to
subdirectories.
Credit to @6speedlt1 on github for identifying the fix.
Fixes #30.