Skip to content

Commit

Permalink
Update notes, add message behavior and versioning details
Browse files Browse the repository at this point in the history
  • Loading branch information
bmhan12 committed Feb 4, 2025
1 parent d71d652 commit 35b5e4b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ to use Open Cascade's file I/O capabilities in support of Quest applications.
- `MFEMSidreDataCollection::LoadExternalData` now takes two optional string parameters, one that is a
filename (defaults to the `name` member variable) and the other is a `Group` path relative to the base of
the Data Collection itself (defaults to the root of the `DataStore`).
- `SLIC_ASSERT`,`SLIC_ASSERT_MSG`,`SLIC_CHECK`, and `SLIC_CHECK_MSG` macros delegate to assert() within HIP device kernels.

### Deprecated

Expand Down
4 changes: 3 additions & 1 deletion src/axom/slic/interface/slic_macros.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,9 @@

/// @}

// Use assert when on device
// Use assert when on device (note that messages are omitted).
// Device HIP assert() tested with [email protected]
// (ROCm support for device assert() begins with version 5.1.0).
#elif defined(AXOM_DEBUG) && defined(AXOM_DEVICE_CODE)
#define SLIC_ASSERT(EXP) assert(EXP)
#define SLIC_ASSERT_MSG(EXP, msg) assert(EXP)
Expand Down

0 comments on commit 35b5e4b

Please sign in to comment.