Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MPI_Init and MPI_Finalize PMPI wrappers #298

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

MichaelBrim
Copy link
Collaborator

@MichaelBrim MichaelBrim commented Mar 26, 2019

Description

Adds a configure option for --enable-mpi-mount, which adds PMPI wrappers for MPI_Init and MPI_Finalize that call unifycr_mount and unifycr_unmount respectively.

Fortran support is also included.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the UnifyCR code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted.

@MichaelBrim
Copy link
Collaborator Author

MichaelBrim commented Apr 2, 2019

I just pushed support for interception on Fortran too. I tested on Summitdev, so this should work on all OpenMPI based platforms. We should find a system where we can test MPICH too.

We should still probably have an explicit Fortran interface for UnifyCR calls like mount/unmount, but this works now for existing Fortran MPI apps.

Copy link
Collaborator

@adammoody adammoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MichaelBrim !

@adammoody adammoody merged commit 24c254e into LLNL:dev Apr 3, 2019
@MichaelBrim MichaelBrim deleted the mpi-mount-unmount branch April 3, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants