Install targets for thirdparty exports #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing this now! |
|
This has resolved the issues discussed in umpire mailing list and umpire issue linked here. Thanks David! |
Thanks for trying it out so quickly 👍 |
|
@rhornung67 I'd like to get this merged before the release - it fixes HIP builds for some of our users. |
rhornung67
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
@davidbeckingsale there were no reviewers listed on this. Do you need anything else?
|
@davidbeckingsale merge this? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bugfix, and exports targets for third-party dependencies provided by BLT (e.g. CUDA and HIP) - this allows non-BLT projects to use the imported RAJA target.