[musig2] use plain points as inputs #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we do the negation check when we create them
so that before finalizing into an "AggKey" you can apply ordinary b32 type tweaks. After finalization you apply only "XOnly" taproot style tweaks.
see: jonasnick/bips#32 for motivation
nickfarrow
added a commit
to nickfarrow/secp256kfun
that referenced
this pull request
Aug 16, 2022
LLFourn
force-pushed
the
musig2-ordinary-points
branch
2 times, most recently
from
0f4c055 to
a7e1655
Compare
So other crates can use it.
LLFourn
force-pushed
the
musig2-ordinary-points
branch
from
a7e1655 to
5ccf590
Compare
LLFourn
changed the title
|
I've just pushed large changes making this compatible with and passing the tests from jonasnick/bips#37 |
LLFourn
force-pushed
the
musig2-ordinary-points
branch
from
5ccf590 to
1c7cb23
Compare
PR is here: jonasnick/bips#37 Notes: - It required allowing for binonce::Nonces with zero points - We now do the "replace by G" if the agg nonce is infinity from the spec - I replaced the keypair types with the new ones from main lib - We can't pass all the test vectors because we don't have the same APIs
LLFourn
force-pushed
the
musig2-ordinary-points
branch
from
1c7cb23 to
54c59d8
Compare
LLFourn
force-pushed
the
musig2-ordinary-points
branch
from
2ede185 to
de73d37
Compare
Add a method to `NonceKeyPair` so we can use it in FROST in future.
LLFourn
force-pushed
the
musig2-ordinary-points
branch
from
de73d37 to
a1d25d7
Compare
nickfarrow
added a commit
to nickfarrow/secp256kfun
that referenced
this pull request
Aug 17, 2022
Following LLFourn#100
nickfarrow
added a commit
to nickfarrow/secp256kfun
that referenced
this pull request
Aug 17, 2022
Following LLFourn#100
nickfarrow
added a commit
to nickfarrow/secp256kfun
that referenced
this pull request
Aug 17, 2022
Following LLFourn#100
nickfarrow
added a commit
to nickfarrow/secp256kfun
that referenced
this pull request
Aug 22, 2022
Following LLFourn#100
nickfarrow
added a commit
to nickfarrow/secp256kfun
that referenced
this pull request
Aug 22, 2022
Following LLFourn#100
LLFourn
pushed a commit
to nickfarrow/secp256kfun
that referenced
this pull request
Sep 6, 2022
Following LLFourn#100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with the idea I put forward here: jonasnick/bips#32.
Since this PR builds upon #97 it already has two phase key aggregation so the change is very simple. The other thing to note is that we were already "pre-negating" the secret keys of keypairs so we don't get any reduction in the number of negation flags we have to keep around (we were down to one already).