Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Check multiplying by infinity returns infinity #13

Closed
LLFourn opened this issue Aug 8, 2020 · 2 comments · Fixed by #20
Closed

Test Check multiplying by infinity returns infinity #13

LLFourn opened this issue Aug 8, 2020 · 2 comments · Fixed by #20

Comments

@LLFourn
Copy link
Owner

LLFourn commented Aug 8, 2020

see: https://github.com/bitcoin-core/secp256k1/pull/791/files

LLFourn added a commit that referenced this issue Aug 12, 2020
@elichai
Copy link

elichai commented Aug 12, 2020

Note, that generally the high level API of libsecp256k1 Doesn't support points at infinity, because those aren't valid public keys and don't have any meaningful serialization

@LLFourn
Copy link
Owner Author

LLFourn commented Aug 13, 2020

This is about the Low level API (ecmult and ecmult_const). It turns out that I was allowing infinity to be passed down to these and then panicking.

The solution is just to check for that and early exit. This is what gmax was suggesting here bitcoin-core/secp256k1#791 (I followed up suggesting it should be applied to ecmult as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants