fix: LIT-3607 - Use StaticJsonRpcProvider to improve performance of RPC requests #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximusHaximus
commented
Jul 16, 2024
MaximusHaximus
commented
Jul 16, 2024
MaximusHaximus
commented
Jul 16, 2024
| new ethers.providers.JsonRpcProvider( | ||
| this.config.rpcUrl || LIT_CHAINS['lit'].rpcUrls[0] | ||
| new ethers.providers.StaticJsonRpcProvider( | ||
| this.config.rpcUrl || RPC_URL_BY_NETWORK[this.config.litNetwork] |
There was a problem hiding this comment.
Fixed a bug here; we were always using LIT_CHAINS['lit'] here. It just so happened that due to internal override logic inside of the contracts SDK this actually worked.
There was a problem hiding this comment.
Should we do this in the constructor instead? so that this.config.rpcUrl is always defined,
eg:
if (!this.config.rpcUrl) {
this.config.rpcUrl = RPC_URL_BY_NETWORK[this.config.litNetwork];
}
MaximusHaximus
commented
Jul 16, 2024
…requests Reference issue - ethers-io/ethers.js#901 Cuts our RPC request cost approx in half by eliminating a sequential call to get `chainId` from every(!) contract call we make
MaximusHaximus
force-pushed
the
LIT-3607-StaticJSONRPCProvider
branch
from
78e85e4 to
91ed6c1
Compare
13 tasks
Ansonhkg
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
|
Just tested this with the pkp mint demo and not only this saves the time on every contract call, it was also making that request in a loop every a few seconds. There is a massive bandwidth and rpc load save as every client would be making those constantly Huge improvement! 🔥 |
FedericoAmura
approved these changes
Jul 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue - ethers-io/ethers.js#901 Cuts our RPC request time costs approximately in half by eliminating a sequential call to get
chainIdfrom every(!) contract call we makeDescription
Replaced ethers JSONRPCProvider instances with StaticJSONRPCProvider
This eliminates unnecessary RPC calls to get
chainIdevery time we use one of our contract methods.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: