add election controlled service endpoints #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature is motivated by the current effort to provide multiple replicas for the linstor-controller. See also this comment describing the issues encountered with v0.1.0 |
Manually setting the endpoints for a service ensures that only the elected pods receive traffic. This works around issues where controlling traffic via pod readiness works suboptimal (i.e. rolling deployments). In rolling deployments, readiness of a pod controls the further roll-out of new versions. This means using readiness to control the service proxy would lead to a deadlock: the new pods would never become "ready" as an old pod still holds the lease, but the old pod is never terminated, as the rolling update only continues if the new pods are ready.
WanzenBug
force-pushed
the
endpoint-control
branch
from
048c7ea to
14018a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually setting the endpoints for a service ensures that only the
elected pods receive traffic. This works around issues where controlling
traffic via pod readiness works suboptimal (i.e. rolling deployments).
In rolling deployments, readiness of a pod controls the further roll-out
of new versions. This means using readiness to control the service proxy
would lead to a deadlock: the new pods would never become "ready" as an old
pod still holds the lease, but the old pod is never terminated, as the rolling
update only continues if the new pods are ready.