Added GKlib and metis submodules, and use cc crate to build the library from source
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhirtz
force-pushed
the
vendor
branch
2 times, most recently
from
e442eb9 to
5499af6
Compare
oisyn
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
LGTM 👍
I saw that you turned the warnings off altogether. Yeah that was bugging me too. I don't know if you saw it but I spent some time this morning adding explicit -Wno-* flags for warnings that triggered on GCC, as those seem to reach the users regardless (when compiling with MSVC, Cargo seems to suppress the warnings output if there are no errors). But this is fine too :)
hhirtz
force-pushed
the
vendor
branch
2 times, most recently
from
3678724 to
57db2f2
Compare
…rary from source Co-authored-by: Hubert Hirtz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #15
cc @oisyn if you have any comments