refactor: restructure core crate source code #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, add NULL definitions for all cell types
also, move in definitions of FloatType & CoordsFloat
cedricchevalier19
approved these changes
Mar 28, 2024
| @@ -0,0 +1,42 @@ | |||
| //! Module short description | |||
There was a problem hiding this comment.
Not sure about having a separate file for that.
These ids are mostly used as internal indices, so keeping them close to data structures also make sense.
There was a problem hiding this comment.
I have grouped them here at the moment since I will be re-implementing data structures for attributes sooner than expected (see #30)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorganize the structure of the core crate into thematically consistent modules. This does not affect the public API, only inner paths.
Scope
honeycombType of change
Other
...
Necessary follow-up
Other: Mention in changelog filedoneMentions
...