Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: simplify and improve consistency #263

Merged
merged 3 commits into from
Jan 8, 2025
Merged

doc: simplify and improve consistency #263

merged 3 commits into from
Jan 8, 2025

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Jan 8, 2025

Description

Associated issue: closes #259

Content description:

  • simplifies a bunch of entries
  • improve consistency overall
  • simplify must_use attribute messages
  • comment out unused strong-typed IDs

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.47%. Comparing base (b67a8ad) to head (c2aa217).

Files with missing lines Patch % Lines
honeycomb-core/src/cmap/builder/structure.rs 36.84% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   77.41%   77.47%   +0.06%     
==========================================
  Files          49       48       -1     
  Lines        6784     6776       -8     
==========================================
- Hits         5252     5250       -2     
+ Misses       1532     1526       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99 imrn99 merged commit 7dfa822 into master Jan 8, 2025
13 checks passed
@imrn99 imrn99 deleted the improve-docs branch January 8, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: simplify all existing doc
2 participants