Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: rework icells & core source structure #26

Closed
wants to merge 55 commits into from
Closed

refactor!: rework icells & core source structure #26

wants to merge 55 commits into from

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Mar 25, 2024 •
edited
Loading

Description

Rework the entire vertex / edge / face management of the map structure. This includes changes such as:

  • incorporate Orbit2 into the CMap2 methods (both for usage & return values)
  • update icell interfaces (e.g. vertex_id, face_id, ...) with the new ID computation logic
  • remove previously used structures that aren't relevant anymore (e.g. DartData, Face, ...)
  • restructure the source code layout in honeycomb-core

To-do:

  • Re-implement the (un)sewing methods
  • Update changelog file
  • Update documentation
  • Update examples
  • implement link methods (identical to sew, without the geometrical update)
  • Update other crates to fit the new API

Scope

  • Code: mainly honeycomb-core, other members are updated to accommodate for the former's changes
  • Documentation

Type of change

  • New feature(s)
  • Refactor

Other

  • Breaking change

Necessary follow-up

...

Mentions

...

imrn99 added 30 commits March 22, 2024 10:36
@imrn99
refactor: update i_cell method return type to use Orbit2
0668e77
@imrn99
feat: add is_isolated method to Orbit2
1d10410
@imrn99
fix: replace older cade that used Vec<IDs> instead of Orbit2
b66d5a5 
this only affects the main crate, I will fix others later
@imrn99
refactor: update cell_id methods with new ID computation system
9bd3c5c
@imrn99
refactor: remove ref from reutrn type of cell_id methods
5adf0c6
@imrn99
refactor: replace vertex storage by a map
67211f7 
the vector doesn't really make sense since cell IDs are not contiguous
anymore; the other solution would be an optimized structure for sparse
vectors
@imrn99
refactor: update old vertex methods
64c22a4 
remove the ones that don't make sense (adds) & insert a todo!() in the
ones remaining
@imrn99
fix: comment out all the code that relied on the old interfaces
0e94a0c
@imrn99
refactor: complete new vertex methods
b50f616
@imrn99
refactor: remove outdated methods & comment out outdated section in code
f0a76bc
@imrn99
refacor: remove outdated face methods
c25c24e
@imrn99
refactor: reorganize CMap2 methods into coherent impl blocks
8969cad
@imrn99
refactor: update Vertex2 init in CMap2 constructor
6e3300f
@imrn99
fix: update constructor usage in twomap.rs
da7db04
@imrn99
refactor: remove DartData structure from CMap2
71a73bc 
with the new ID methods, it was not used anymore
@imrn99
refactor: remove DartData, CellIdentifiers & Face code
3715816
@imrn99
refactor: move all id types to new dedicated module
7e91635
@imrn99
doc: remove outdated example
edf10d1 
will replace it later
@imrn99
fix: update size methods
8f2ef33 
they probably should be cahnged further, but atm this is what's
necessary for the doc to compile
@imrn99
refactor: move all spatial representation types to dedicated module
332b951
@imrn99
feat: add new structures for icell collection
e1836bf
@imrn99
feat: complete new cell collection methods
81c3b2e
@imrn99
fix: update test in honeycomb-core crate
b3e1b70
@imrn99
refactor: move orbits module to cells module
04bd1f4
@imrn99
fix: remove commented out code & dummy tests
c54e40b
@imrn99
feat: add link methods
ea16111 
also replace the code in sew ops by call to the new methods
@imrn99
doc: update twomap.rs doc 1/?
bb532a7
@imrn99
doc: update twomap.rs documentation 2/?
76a1dab
@imrn99
doc: update twomap.rs documentation 3/?
9752d03
@imrn99
doc: updaet twomap.rs documentation 4/4
c5cd804
imrn99 added 25 commits March 25, 2024 16:17
@imrn99
fix: update generation functions & squaremap test
87895e9
@imrn99
fix: update splitmap test
f7ac240
@imrn99
fix: update core/editing benchmarks
630658e
@imrn99
fix: update core/reading & sewing benchmarks
7e74e0e 
some of those don't really make sense anymore (e.g. i_cell bench with
orbits)
@imrn99
fix: update criterion benchmarks
e12aaa0
@imrn99
fix: update honeycomb-render handle code
caaa6bc 
its probably highly inefficient atm, but it compiles
@imrn99
chore: remove unused imports, remove deref op from face_id iterator
e833e28
@imrn99
feat: implement StretchLeft sewing code for one_sew
f16232f
@imrn99
refactor: use remove_vertex method to get new value directly in one_sew
3c3b1c0
@imrn99
feat: complete StretchRight & StretchAverage code for 1-sew
4bc0760
@imrn99
fix: add else clause to one_sew to handle trivial case
44771bb
@imrn99
feat: complete one_unsew Duplicate code
076d9af
@imrn99
fix: remove unused import
6a2d2df
@imrn99
chore: update two_sew comments to clarify what the method is doing
692d57f
@imrn99
feat: complete one case of the two_sew method
f660479
@imrn99
feat: complete 2-sew implementation
10b6451
@imrn99
fix: update generation::square_cmap2 function
570559a
@imrn99
feat: add better error signaling to one_sew
c17aa5c
@imrn99
refactor: change all error handling in two_sew method
d0f7213
@imrn99
refactor: rewrite splitsquare_cmap2 to be independent from square_cmap2
afca205 
also update its test accordingly
@imrn99
fix: remove unused import, add PhantomData to collection types
e935ad5
@imrn99
fix: change set_vertex call to insert_vertex in generation functions
585fd75
@imrn99
fix: change vertex orbits computations to handle incomplete vertices
9989157
@imrn99
fix: update splitsquare_cmap2 function with correct boundary indices
68d3aa3
@imrn99
feat: reimplement two_unsew duplicate policy
380ae0a
@imrn99
Copy link
Collaborator Author

imrn99 commented Mar 27, 2024

Closing the PR because of issues with the reworked code. I'll continue testing things out on the rework-icells branch & will figure out how to cleanly merge the changes via new branches.

@imrn99 imrn99 closed this Mar 27, 2024
@imrn99 imrn99 mentioned this pull request Apr 12, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@imrn99