Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(core): delete the io feature from the core crate #255

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Dec 12, 2024

Description

Scope: core

Type of change: refactor

Content description:

  • remove the io feature from honeycomb-core
  • fuse files of the io builder submodule into a single one & move tests
  • rename the io dim2 submodule to serialize since it contains only write logic

Additional information

  • Breaking change

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.98%. Comparing base (739dc00) to head (c4567cc).

Files with missing lines Patch % Lines
honeycomb-core/src/cmap/builder/tests.rs 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   79.81%   77.98%   -1.84%     
==========================================
  Files          48       47       -1     
  Lines        6747     6676      -71     
==========================================
- Hits         5385     5206     -179     
- Misses       1362     1470     +108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99 imrn99 merged commit 2b7e7fc into master Dec 12, 2024
13 checks passed
@imrn99 imrn99 deleted the remove-io-feature branch December 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants