refactor(core): rewrite grid building routines #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bench confirm perf is slightly better. more importantly, parallelizing the new one won't result in transaction conflicts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
==========================================
- Coverage 79.21% 78.87% -0.35%
==========================================
Files 52 52
Lines 6953 6779 -174
==========================================
- Hits 5508 5347 -161
+ Misses 1445 1432 -13 ☔ View full report in Codecov by Sentry. |
|
CI fails due to new Rust version, I'll fix it in another PR |
cedricchevalier19
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scope: core
Type of change: refactor of internals
Content description:
The new routines compute separately the value of the beta functions and manually store them for each dart (instead of using sews and links). Vertices are added after beta functions are fully defined.
There is a slight improvement in performance (5-10%), but this is not the interesting change. With the new routines, there won't be any conflict between transactions when parallelized. every write operation is containerized, and does not affect data read by another transaction.