Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update manager methods #239

Closed
wants to merge 2 commits into from
Closed

update manager methods #239

wants to merge 2 commits into from

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Nov 25, 2024

Description

Associated issue: closes #233

Content description: TODO

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.17%. Comparing base (6302125) to head (7d2ae9a).

Files with missing lines Patch % Lines
honeycomb-core/src/attributes/manager.rs 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
+ Coverage   78.97%   79.17%   +0.20%     
==========================================
  Files          52       52              
  Lines        6834     6820      -14     
==========================================
+ Hits         5397     5400       +3     
+ Misses       1437     1420      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99
Copy link
Collaborator Author

imrn99 commented Dec 3, 2024

I'll be waiting on API validation to complete this. If we remove some methods (e.g. just keep try variants), I'll ensure there's no more nested Result/Option

@imrn99
Copy link
Collaborator Author

imrn99 commented Dec 10, 2024

closing in favor of other PRs (e.g. #247)

@imrn99 imrn99 closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: expand CMapError variants and usage
2 participants