Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build and test fail #8

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix build and test fail #8

merged 1 commit into from
Aug 15, 2024

Conversation

notatiyyah
Copy link
Contributor

The docker-composecommand is failing in the pipeline, but looks like it passes when I use docker compose instead. See this issue thread.

Duslerke
Duslerke approved these changes Aug 15, 2024
View reviewed changes
Copy link

@Duslerke Duslerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting change they did.
I suppose it does make sense given docker-compose was always just a wrapper around docker 🤔

@notatiyyah notatiyyah merged commit f7811e8 into main Aug 15, 2024
5 checks passed
@notatiyyah notatiyyah deleted the feature/update-pipeline branch August 15, 2024 11:05
@notatiyyah notatiyyah mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duslerke Duslerke Duslerke approved these changes

@LBHMKeyworth LBHMKeyworth Awaiting requested review from LBHMKeyworth LBHMKeyworth is a code owner

@LBHSPreston LBHSPreston Awaiting requested review from LBHSPreston LBHSPreston is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notatiyyah @Duslerke